Fwd: [folio-org/ui-users] address edit enhancement (#895)
Uschi Klute
(12 Jul 2019 04:59 EDT)
|
RE: [folio-org/ui-users] address edit enhancement (#895)
Jackie Gottlieb
(12 Jul 2019 16:56 EDT)
|
Re: [folio-org/ui-users] address edit enhancement (#895)
Philip Robinson
(13 Jul 2019 09:02 EDT)
|
RE: [folio-org/ui-users] address edit enhancement (#895)
Cate Boerema
(15 Jul 2019 05:11 EDT)
|
Re: [folio-org/ui-users] address edit enhancement (#895)
Uschi Klute
(15 Jul 2019 06:04 EDT)
|
RE: [folio-org/ui-users] address edit enhancement (#895)
Erin Nettifee
(15 Jul 2019 08:59 EDT)
|
RE: [folio-org/ui-users] address edit enhancement (#895) Cate Boerema (15 Jul 2019 11:43 EDT)
|
Thanks, Erin. I think pointing them to Patty was the right move. -----Original Message----- From: Erin Nettifee <erin.nettifee@duke.edu> Sent: 15 July 2019 02:59 PM To: user-mgmt@ole-lists.openlibraryfoundation.org; Cate Boerema <cboerema@EBSCO.COM> Subject: RE: [folio-org/ui-users] address edit enhancement (#895) CAUTION: External E-mail I added a comment to the Github thread this morning asking that if they want to do this, that it be brought back to Patty for discussion. Cate - I'm not sure if more is needed here. Erin -----Original Message----- From: user-mgmt@ole-lists.openlibraryfoundation.org <user-mgmt@ole-lists.openlibraryfoundation.org> On Behalf Of Uschi Klute Sent: Monday, July 15, 2019 6:05 AM To: user-mgmt@ole-lists.openlibraryfoundation.org; Cate Boerema <cboerema@EBSCO.COM> Subject: Re: [folio-org/ui-users] address edit enhancement (#895) Hi Cate, Thank you so much for taking up this subject. Am 15.07.2019 um 11:11 schrieb Cate Boerema: > Hi UM SIG, > > I was working with the SIG back when the Address component was designed so I wanted to provide a bit of context around the thinking at that time. > > It was assumed at that time that most user records would be populated via feed from an external ("source") system (like the university student information system). Given that, we said: > 1. We don't need to optimize the UX for manually adding addresses in > FOLIO I agree > 2. The source systems would have the data validation needed so FOLIO didn't need extensive validation. In fact, if FOLIO had data validation and controlled vocabularies, these would need to be kept closely in synch with the source systems or there could be problems with integrations. That's my opinion, too. > > The simple address component implemented at the time met the needs of the institutions represented on the SIG. It mirrors the address elements used by Amazon in many countries worldwide. > > This is not to say that adjustments aren't needed. I just wanted to shed some light on the initial thinking. Who will tell the developers not to work further on this "issue"? https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio-2Dorg_ui-2Dusers_pull_895&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=V6wYZ_ugeMEfaUTYQDN-iDFY0gVE7E-duUuihBgxZuM&m=4rKdoVhkqsZ5CtMJL72fFYHM7s79cL3h96s4APVI0iY&s=fDGG2eKC4kTbRTvHbYpI2tTMV9LewnS77iUrSYPahuo&e= Viele Grüße Uschi > -----Original Message----- > From: user-mgmt@ole-lists.openlibraryfoundation.org > <user-mgmt@ole-lists.openlibraryfoundation.org> On Behalf Of Jackie > Gottlieb > Sent: 12 July 2019 10:56 PM > To: user-mgmt@ole-lists.openlibraryfoundation.org > Subject: RE: [folio-org/ui-users] address edit enhancement (#895) > > CAUTION: External E-mail > > > I agree that locking address fields to a specific hierarchy is going to cause issues for countries/locations that use these fields differently. It will greatly reduce the flexibility we need in order to be an international solution. The fields need to remain free text and they should be reviewed to confirm that 3 fields meet the wide range of needs. And if not, that custom address fields can be added. Requiring these fields when a location may not use it the same way can also become an issue. > > -----Original Message----- > From: user-mgmt@ole-lists.openlibraryfoundation.org > <user-mgmt@ole-lists.openlibraryfoundation.org> On Behalf Of Uschi > Klute > Sent: Friday, July 12, 2019 4:59 AM > To: user-mgmt@ole-lists.openlibraryfoundation.org > Subject: Fwd: [folio-org/ui-users] address edit enhancement (#895) > > Hi all, > > It looks as if there is the idea for having a selection list for the fields "State/Prov./Region", "Zip/Postal code" and "City". > In addition, I have the impression that then you could only enter the city and zip code after you have selected a "State/Prov./Region" before. > > Selection list: > It is not predictable from which places (also from other countries) the users come, therefore in my opinion a free text input in the fields should still be possible. > > Hierarchical dependence of the fields: > We also have a field "State/Prov./Region" (in German: "Bundesland"), which is practically never filled. Therefore, it would be a hindrance for our GBV libraries if they had to use the field actively. > A dependency of the three fields (only if one field is filled in, you can use the next one) does not seem appropriate to me. > > But maybe I misunderstood that? What do you think about this? > Uschi > > P.S. Welcome, Patty! ;-) > > > > -------- Weitergeleitete Nachricht -------- > Betreff: [folio-org/ui-users] address edit enhancement (#895) > Datum: Wed, 10 Jul 2019 23:06:13 -0700 > Von: AlenYao <notifications@github.com> > Antwort an: folio-org/ui-users > <reply+AF7KUWFDUOKWDVWR2NDG4AN3GQCFLEVBNHHBXUH32E@reply.github.com> > An: folio-org/ui-users <ui-users@noreply.github.com> > Kopie (CC): Subscribed <subscribed@noreply.github.com> > > > > Currently, there are three value 'State/Prov./Region', 'city' and 'Zip/Postal Code', now, i want to change the component to 'Select', and implement cascade relationship for the three values, i mean, first select 'Prov', then get 'city' dataOptions, after select 'city', get the 'code' dataOptions, I use onChange() event and already works fine when create action(the case in create a user), but 'city' and 'code' value cannot be display for update action(edit a existing user). I know, the reason is onChange() event is not be triggered, dataOptions for 'city' > and 'code' are null when update action > > ---------------------------------------------------------------------- > -- > > > You can view, comment on, or merge this pull request online at: > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio- > 2Dorg_ui-2Dusers_pull_895&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR > 0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3 > hdMmuJwuaXU&s=EpJ92hGMJcCGFY8Ft0MHM0PFvTarUVv7ARKPnjRK2l0&e= > > > Commit Summary > > * address edit enhancement > > > File Changes > > * *A* src/components/EditSections/EditContactInfo/AddressEdit.css > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio-2Dorg_ui-2Dusers_pull_895_files-23diff-2D0&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=Atyhg17PPC_mJj_Ew3u6ee8c7STBOfyFakXbc0qylpI&e=> (110) > * *A* src/components/EditSections/EditContactInfo/AddressEditList.js > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio-2Dorg_ui-2Dusers_pull_895_files-23diff-2D1&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=x202xpZpidjpAGnwWn2qXoRhw5hqi-f8fG_5NwzI_1I&e=> (96) > * *A* src/components/EditSections/EditContactInfo/AddressSel.js > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio-2Dorg_ui-2Dusers_pull_895_files-23diff-2D2&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=v4CxwSHC90zLv5A83XhDSHO2x7AXFHu5XMaEJwe7dWI&e=> (263) > * *M* src/components/EditSections/EditContactInfo/EditContactInfo.js > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio-2Dorg_ui-2Dusers_pull_895_files-23diff-2D3&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=9M39wLn3cq72CAbdq40nHah8SWBh20x-S3hY_lG-Nes&e=> (3) > * *A* src/data/addressData.js > > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio > -2Dorg_ui-2Dusers_pull_895_files-23diff-2D4&d=DwIDaQ&c=imBPVzF25OnBgGm > VOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOr > n2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=_mRzLkvXMTXd3Y6wMoQclO1-Z32_i-UCfJ_FLc > Q16kI&e=> (35) > > > Patch Links: > > * https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio-2Dorg_ui-2Dusers_pull_895.patch&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=BpTWPEy2gErjn9ui2lAD_xam6MXL_tcTeH4xU3FkKUM&e= > * > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio- > 2Dorg_ui-2Dusers_pull_895.diff&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i > 6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkV > HTCv3hdMmuJwuaXU&s=_EE4mW1WuVpV5Zy5tPQgBHHrPC0x-9WM_MNlcK060VY&e= > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_folio > -2Dorg_ui-2Dusers_pull_895-3Femail-5Fsource-3Dnotifications-26email-5F > token-3DAF7KUWGSSDN5QLMHOZKRGU3P63EVLA5CNFSM4IAVGLFKYY3PNVWWK3TUL52HS4 > DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6Q7PIQ&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcs > iEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXt > d7IA9PkVHTCv3hdMmuJwuaXU&s=7O1jKSUsCPx5kIlJEYb6dzUY75-wiNe0DI3Fs0YW5So > &e=>, > or mute the thread > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AF7KUWBKRIA2VCF5EAZ7AT3P63EVLANCNFSM4IAVGLFA&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=AFpUuqLrvCgBb_8xe6omlFtQZmfeOZx96nu-ltILWas&e=>. > > > -- > Uschi Klute > Verbundzentrale des GBV (VZG) > Lokale Bibliothekssysteme > Von-Melle-Park 3, 20146 Hamburg > Tel. 040 / 42838-6377 > E-Mail Uschi.Klute@gbv.de > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.gbv.de&d=DwID > aQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp > 0fQ&m=Fiu9M63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=pwFilXKQ3HziVc9-LB > kknG2pwF2y5eYNMurf5wNUhXg&e= To unsubscribe from this list please go > to > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.simplelists.co > m_confirm.php-3Fu-3D8c6B5PECnUNdqFGbrX44gWoEVzSUjhRe&d=DwIDaQ&c=imBPVz > F25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=3u0F5HjEcEMPDL8aNfp0fQ&m=Fiu9M > 63JHrBJOrn2WXtd7IA9PkVHTCv3hdMmuJwuaXU&s=wKOokmqWNp6YGXeCEVuOc3z8nixep > A5j8g8JtRk6y3Q&e= To unsubscribe from this list please go to > https://urldefense.proofpoint.com/v2/url?u=http-3A__archives.simplelis > ts.com&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=V6wYZ_ > ugeMEfaUTYQDN-iDFY0gVE7E-duUuihBgxZuM&m=4rKdoVhkqsZ5CtMJL72fFYHM7s79cL > 3h96s4APVI0iY&s=hCCQZU-Hc-TywmPaRXfyXFWTr-HkLP9C387xvsb-T7U&e= > To unsubscribe from this list please go to > https://urldefense.proofpoint.com/v2/url?u=http-3A__archives.simplelis > ts.com&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=V6wYZ_ > ugeMEfaUTYQDN-iDFY0gVE7E-duUuihBgxZuM&m=4rKdoVhkqsZ5CtMJL72fFYHM7s79cL > 3h96s4APVI0iY&s=hCCQZU-Hc-TywmPaRXfyXFWTr-HkLP9C387xvsb-T7U&e= > -- Uschi Klute Verbundzentrale des GBV (VZG) Lokale Bibliothekssysteme Von-Melle-Park 3, 20146 Hamburg Tel. 040 / 42838-6377 E-Mail Uschi.Klute@gbv.de https://urldefense.proofpoint.com/v2/url?u=https-3A__www.gbv.de&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=V6wYZ_ugeMEfaUTYQDN-iDFY0gVE7E-duUuihBgxZuM&m=4rKdoVhkqsZ5CtMJL72fFYHM7s79cL3h96s4APVI0iY&s=G8cpEUxJjz_OVq26tgLXFmDET35JqmQT0rDFsRTtZJQ&e= To unsubscribe from this list please go to https://urldefense.proofpoint.com/v2/url?u=http-3A__www.simplelists.com_confirm.php-3Fu-3DmSqmaJzM1rGNkoh00drADsavQrz31wcM&d=DwIDaQ&c=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc&r=V6wYZ_ugeMEfaUTYQDN-iDFY0gVE7E-duUuihBgxZuM&m=4rKdoVhkqsZ5CtMJL72fFYHM7s79cL3h96s4APVI0iY&s=o5DZh8-EwJa3zEilchpfeS5Qu4I0hEhA-sDqVExmjCw&e=